whitelisted_ips configuration should be specific #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can put this statement for the whole config. Can you add a question/answer to the FAQ section? |
| @@ -108,10 +108,10 @@ By default, only requests coming from IPv4 and IPv6 localhosts are allowed. | |||
| the console. | |||
|
|
|||
| You can whitelist single IP's or whole networks. Say you want to share your | |||
| console with `192.168.0.100`. You can do this: | |||
| console with `192.168.0.100`. You can do this on your development environment: | |||
There was a problem hiding this comment.
Can you drop this? See the main comment.
|
@frenesim Sory for the late response. Can you rebase and squash those commits? |
|
I will do On Fri, Jun 19, 2015, 12:35 Genadi Samokovarov notifications@github.com
|
FAQ for undefined method
frenesim
force-pushed
the
frenesim-patch-1
branch
from
c0a0de4
to
6871f96
Compare
|
@frenesim ping 😸 |
|
I'll introduce those changes before release. Thank you for bringing the topic up and helping us out with the docs. I'll make sure I credit you in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whitelisted_ips should be in the a dedicated environment configuration file.