Display a message with the IP web-console is seeing #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
strict-ip-logging
branch
from
fd4dd0d
to
2676772
Compare
| @@ -5,8 +5,8 @@ module WebConsole | |||
| # return false, an info log message will be displayed in users' logs. | |||
| class WhinyRequest < SimpleDelegator | |||
| def from_whitelisted_ip? | |||
| whine_unless request.from_whitelisted_ip? do | |||
| "Cannot render console from #{request.remote_ip}! " \ | |||
| whine_unless request.from_whitelited_ip? do | |||
There was a problem hiding this comment.
The correctly-spelled name is the right one since #170... which means this should probably be causing a test failure somewhere? 馃槙
There was a problem hiding this comment.
You are right, I have messed it up during a rebase. Should be fixed now.
|
This is the correct fix; there is no other issue, as far as I can see. |
gsamokovarov
force-pushed
the
strict-ip-logging
branch
from
2676772
to
9c6ffec
Compare
gsamokovarov
added a commit
that referenced
this pull request
Oct 28, 2015
Display a message with the IP web-console is seeing
|
Which is the correct gem to download to get this fix? I have web-console (2.2.1) !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of the problem reported at #164. However, it doesn't fix the issue, though. 馃槥 It just gives the users better idea of what address web-console is actually seeing.
This is happening for developers running web-console in a virtual machine or a container with a Rails app behind an nginx or Apache proxy.
EDIT:
Actually @matthewd is correct (as always 馃槉). The problem @brunze was getting was because in the docker setup, we are getting through two networks, so can't trust one and not the other, we have to trust both, to be sure that we can execute arbitrary code in there. Hopefully, with the proper display of the IP, folks will get hinted about this. I'll also try to document it for the next release.