Fix rails console invocation inside a Rails app #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Railties can hook themselves into the `rails console` with:
```ruby
class Railtie < ::Rails::Railtie
console do
# Do something here.
end
end
```
Now, since I introduced the `#console` method in `Kernel`, every object
responded to it, so this block was tried to be run on railties that
respond to it.
Marking the `#console` method _explicitly_ as `module_function`
solves this problem as it makes it `private` and the `#respond_to?`
calls during the railties initialization no longer lie.
Fixes #184.
|
Thanks so quick fix, confirm works. |
gsamokovarov
added a commit
that referenced
this pull request
Jan 28, 2016
Fix rails console invocation inside a Rails app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Railties can hook themselves into the
rails consolewith:Now, since I introduced the
#consolemethod inKernel, every objectresponded to it, so this block was tried to be run on railties that
respond to it.
Marking the
#consolemethod explicitly asmodule_functionsolves this problem as it makes it
privateand the#respond_to?calls during the railties initialization no longer lie.
Fixes #184.