Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence ActionView rendering information #189

Merged
merged 1 commit into from Feb 29, 2016

Conversation

gsamokovarov
Copy link
Collaborator

We use Action View a lot in web-console. It helps us build the UI we
inject on pages. However, using that much partials do make Action View
a tad too noisy.

We may have the argument that keeping this explicit is a good thing, and
we can see that web-console's rendering is actually slow.

However I would like to make the argument that web-console is an
internal thing as is and I'm doing this for the convenience of less
noise in the development logs.

Before:

StandardError (StandardError):

app/controllers/exception_test_controller.rb:13:in `test_method'
app/controllers/exception_test_controller.rb:4:in `index'
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb (2.8ms)
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (1.3ms)
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (7.9ms)
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (65.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/index.html.erb
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_markup.html.erb (0.3ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/console.js.erb within layouts/javascript
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/_inner_console_markup.html.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_inner_console_markup.html.erb within layouts/inlined_string (0.3ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/_prompt_box_markup.html.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_prompt_box_markup.html.erb within layouts/inlined_string (0.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/style.css.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/style.css.erb within layouts/inlined_string (0.4ms)
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/console.js.erb within layouts/javascript (29.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/main.js.erb within layouts/javascript
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/main.js.erb within layouts/javascript (0.3ms)
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/index.html.erb (53.6ms)

After:

StandardError (StandardError):

app/controllers/exception_test_controller.rb:13:in `test_method'
app/controllers/exception_test_controller.rb:4:in `index'
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb (2.6ms)
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (1.3ms)
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (7.0ms)
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (47.5ms)

We use Action View a lot in web-console. It helps us build the UI we
inject on pages. However, using that much partials do make Action View
a tad too noisy.

We may have the argument that keeping this explicit is a good thing, and
we can see that web-console's rendering is actually slow.

However I would like to make the argument that web-console is an
internal thing as a it is and I'm doing this for the continence of less
noise in the development logs.

```
StandardError (StandardError):

app/controllers/exception_test_controller.rb:13:in `test_method'
app/controllers/exception_test_controller.rb:4:in `index'
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb (2.8ms)
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (1.3ms)
  Rendering /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (7.9ms)
  Rendered /Users/genadi/.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/bundler/gems/rails-6fb31638c8b6/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (65.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/index.html.erb
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_markup.html.erb (0.3ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/console.js.erb within layouts/javascript
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/_inner_console_markup.html.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_inner_console_markup.html.erb within layouts/inlined_string (0.3ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/_prompt_box_markup.html.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/_prompt_box_markup.html.erb within layouts/inlined_string (0.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/style.css.erb within layouts/inlined_string
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/style.css.erb within layouts/inlined_string (0.4ms)
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/console.js.erb within layouts/javascript (29.2ms)
  Rendering /Users/genadi/Development/web-console/lib/web_console/templates/main.js.erb within layouts/javascript
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/main.js.erb within layouts/javascript (0.3ms)
  Rendered /Users/genadi/Development/web-console/lib/web_console/templates/index.html.erb (53.6ms)
```

```
StandardError (StandardError):

app/controllers/exception_test_controller.rb:13:in `test_method'
app/controllers/exception_test_controller.rb:4:in `index'
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_source.html.erb (2.6ms)
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (1.3ms)
  Rendering /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (7.0ms)
  Rendered /Users/genadi/Development/rails-dev-box/rails/actionpack/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (47.5ms)
```
gsamokovarov added a commit that referenced this pull request Feb 29, 2016
Silence ActionView rendering information
@gsamokovarov gsamokovarov merged commit deffb65 into rails:master Feb 29, 2016
@gsamokovarov gsamokovarov deleted the silence-render branch March 17, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant