Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore error in parsing remote address #230

Merged
merged 2 commits into from
Feb 17, 2017

Conversation

akirakoyasu
Copy link

whitelist.include?(network.to_s) raises an error in parsing remote address in case the address is not IPv4 or IPv6 format.

I met the case on an environment that the rails-server is used as upstream of nginx proxy through an unix socket. At that time, the remote address is "unix:".

Signed-off-by: Akira Koyasu <mail@akirakoyasu.net>
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @gsamokovarov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gsamokovarov
Copy link
Collaborator

Interesting case. Do you mind adding a test for it?

Signed-off-by: Akira Koyasu <mail@akirakoyasu.net>
@akirakoyasu
Copy link
Author

Thanks. added test.

@gsamokovarov gsamokovarov merged commit 7fabe8b into rails:master Feb 17, 2017
@gsamokovarov
Copy link
Collaborator

Thanks! 🥛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants