-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nested exceptions #265
Add support for nested exceptions #265
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @gsamokovarov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks @yuki24, left a few comments, but overall, it looks good! |
@yuki24 I'm planning to merge this as is and do a few changes afterward myself. You can get back to it in a bit. |
I'm okay with that if you don't mind the test failures in CI. Let me know if there's anything I could help out! |
Alright, I've addressed the comments and added more test coverage. Let's touch base after the lightning talk. |
Thank you! 🙇♂️ |
This PR depends on rails/rails#32410.
This PR adds support for nested exceptions that is being discussed in the upstream Rails. The idea is to add an object scope using the
exception_object_id
and pass it to the web console session along with theframe_id
, so the session will be able to switch the binding to the specified frame in the appropriate exception.Obviously, there needs to be some test overage around this as this is touching the core functionality of the gem. But please let me know if there is any feedback.