Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nested exceptions #265

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Add support for nested exceptions #265

merged 1 commit into from
Apr 19, 2019

Conversation

yuki24
Copy link

@yuki24 yuki24 commented Jul 16, 2018

This PR depends on rails/rails#32410.

This PR adds support for nested exceptions that is being discussed in the upstream Rails. The idea is to add an object scope using the exception_object_id and pass it to the web console session along with the frame_id, so the session will be able to switch the binding to the specified frame in the appropriate exception.

Obviously, there needs to be some test overage around this as this is touching the core functionality of the gem. But please let me know if there is any feedback.

  • Add more test coverage

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @gsamokovarov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@gsamokovarov
Copy link
Collaborator

Thanks @yuki24, left a few comments, but overall, it looks good!

@gsamokovarov
Copy link
Collaborator

@yuki24 I'm planning to merge this as is and do a few changes afterward myself. You can get back to it in a bit.

@yuki24
Copy link
Author

yuki24 commented Feb 25, 2019

I'm okay with that if you don't mind the test failures in CI. Let me know if there's anything I could help out!

@yuki24 yuki24 changed the title WIP: Add support for nested exceptions Add support for nested exceptions Apr 19, 2019
@yuki24
Copy link
Author

yuki24 commented Apr 19, 2019

Alright, I've addressed the comments and added more test coverage. Let's touch base after the lightning talk.

@gsamokovarov gsamokovarov merged commit b249558 into rails:master Apr 19, 2019
@gsamokovarov
Copy link
Collaborator

Thank you! 🙇‍♂️

@yuki24 yuki24 deleted the support-for-nested-exceptions branch April 19, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants