Ruby 3 compat #306
Merged
Ruby 3 compat #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.0 changes behavior of `binding.eval` [[1]] resulting in test failure: ~~~ WebConsole::EvaluatorTest#test_Evaluator_callers_are_cleaned_up_of_unneeded_backtraces [/home/travis/build/rails/web-console/test/web_console/evaluator_test.rb:63]: --- expected +++ actual @@ -1,3 +1,3 @@ "RuntimeError: oops -\tfrom /home/travis/build/rails/web-console/test/web_console/evaluator_test.rb:61:in `block in <class:EvaluatorTest>' +\tfrom (eval):1:in `block in <class:EvaluatorTest>' ~~~ Fixes rails#301 [1]: https://bugs.ruby-lang.org/issues/17419
This is not really necessary ATM, but should the condition introduced by 1a2a9f8 be removed one day, it will be needed anyway.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #301.
I have split the PR into two commits. I think the first is essential while the second is NTH.
Also note that there are already similar Ruby 2.6+ condition:
web-console/lib/web_console/source_location.rb
Line 8 in 167c240
therefore maybe
RUBY_VERSIONshould be used instead ofrespond_to?