[FIX #331] Add simultaneous support for Rack 2 and 3 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeDupuis
changed the title
skipkayhil
reviewed
Aug 22, 2023
| @@ -52,7 +52,7 @@ def call(env) | |||
| private | |||
|
|
|||
| def acceptable_content_type?(headers) | |||
| headers["content-type"].to_s.include?("html") | |||
| headers[Rack::CONTENT_TYPE].to_s.include?("html") | |||
There was a problem hiding this comment.
There's another "content-type" 5 lines below
There was a problem hiding this comment.
The other one was not causing an issue, since we had no conditional on it, but I updated it and the other references too for the sake of consistency. They were mostly tests.
I left this one
I see it as separate since It's on the request side. Just like we can't control the casing from a browser request.
It's in an ERB file, so we could use same constant, but it would make the code a bit uglier.
Do you prefer to change it too?
There was a problem hiding this comment.
No, I agree with you that one should be fine since its a request header (Rack 3 only requires response headers to be downcasesd)
JoeDupuis
force-pushed
the
support-rack-2-and-3
branch
from
ee6f0fe
to
1cc5bf0
Compare
JoeDupuis
force-pushed
the
support-rack-2-and-3
branch
from
1cc5bf0
to
33f6d58
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#318 introduced a regression (#331) for apps running Rack 2.
Rack 3 follows the HTTP 2 spec and requires lower case headers.
By using the Rack header constants we get the correct capitalization regardless of which rack version is loaded.
Considerations