Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autofocus when initializing the console #86

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

ryandao
Copy link

@ryandao ryandao commented Dec 7, 2014

Accoring to #85 and #65, autofocusing the console is quite annoying.

@chancancode
Copy link
Member

Why was the console capturing Ctrl + R anyway? Can't we just make sure we are capturing only the keys we need and maybe add Esc to unfocus the console? @colszowka seems like that would satisfy your complain?

@sime would that work for you? Or do you have other issues with it?

@sime
Copy link

sime commented Dec 7, 2014

Personally I would prefer it unfocused on load rather than needing a
keystroke to do so.
On 7 Dec 2014 06:59, "Godfrey Chan" notifications@github.com wrote:

Why was the console capturing Ctrl + R anyway? Can't we just make sure we
are capturing only the keys we need and maybe add Esc to unfocus the
console? @colszowka https://github.com/colszowka seems like that would
satisfy your complain?

@sime https://github.com/sime would that work for you? Or do you have
other issues with it?


Reply to this email directly or view it on GitHub
#86 (comment).

@ryandao
Copy link
Author

ryandao commented Dec 7, 2014

The console actually is not registered to key combinations, so ctrl+r should work. Cmd+r works fine on Mac. Maybe it's an old version issue?

However, I'd prefer the console to be unfocused by default. Other people may also find it annoying.

@chancancode
Copy link
Member

If you inserted a <%= console %> helper and reloaded the page, it seems like a pretty clear signal that you intend to interact with the console. Perhaps the case is less strong on the error pages, but then there's not much else you can do on that page, so the autofocus doesn't seem like a problem to me personally.

Anyway, I don't feel strongly about this one way or the other, but we should probably figure out why Ctrl + R is not working.

@jonatack
Copy link

jonatack commented Dec 7, 2014

I agree with @sime, @colszowk and others who find it annoying on error pages. It's a bit of a workflow-breaker to not be able to fix the error in one window, then return to the browser with a quick cmd-tab followed by cmd-r to refresh like before.

@creativelycloudy
Copy link

Definitely agree on this one. During development, I have the console hidden on each page with the ability to toggle its display whenever I need it (have found this incredibly useful).

Having the console display focused really kills my workflow when trying to quickly test pages in my app that have autofocused form fields.

I'd love the ability to tell the console to remain unfocused on load.

@gsamokovarov
Copy link
Collaborator

Agree with all of you. Will merge this as is, but I think @chancancode has the better idea here and we can investigate further why we eat up all the key combinations and how we can resolve it for good. Having the listeners on document may interfere with devs applications.

@ryandao, please, make the PRs from your fork from now on.

gsamokovarov added a commit that referenced this pull request Dec 9, 2014
Disable autofocus when initializing the console
@gsamokovarov gsamokovarov merged commit 3ee30bf into master Dec 9, 2014
@gsamokovarov gsamokovarov deleted the disable_auto_focus branch December 9, 2014 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants