Railtie yarn check --integrity fails on development

[doits]

just updated to 3.4.0 and I get this:

========================================
  Your Yarn packages are out of date!
  Please run `yarn install` to update.
========================================


To disable this check, please add `config.webpacker.check_yarn_integrity = false`
to your Rails development config file (config/environments/development.rb).


yarn check v1.5.1
warning package.json: No license field
warning No license field
warning Integrity check: Flags don't match
error Integrity check failed
error An unexpected error occurred: "Found 1 errors.".
info If you think this is a bug, please open a bug report with the information provided in "/Users/markus/svn/caseman-events/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

If I run it manually, everything is fine:

→   yarn check --integrity                                                                                                                                                                       [demo/develop]
yarn check v1.5.1
warning package.json: No license field
warning No license field
success Folder in sync.
   Done in 0.10s.

If I use NODE_ENV=production I can reproduce it:

→   NODE_ENV=production yarn check --integrity                                                                                                                                                   [demo/develop]
yarn check v1.5.1
warning package.json: No license field
warning No license field
warning Integrity check: Flags don't match
error Integrity check failed
error An unexpected error occurred: "Found 1 errors.".
info If you think this is a bug, please open a bug report with the information provided in "/Users/markus/svn/caseman-events/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

If I install with production ...

NODE_ENV=production yarn install

... I can use rails again and the rails integrity check works. But of course I want to use my development yarn packages, so this is no solution.

The problems seems to be that yarn check --integrity is run with NODE_ENV=producion, even locally when developing.

[gauravtiwari]

@doits When is this happening -running binstubs or rake tasks?

[doits]

It happened to me when trying to upgrade the binstubs

bundle exec rails webpacker:binstubs

[keyranova]

This is happening to me on a fresh install:

created a new app (this step seemed to work fine):

rails new install_test --webpack

created databases:

rails db:create

then tried starting server

rails server

output:

=> Booting Puma
=> Rails 5.1.5 application starting in development
=> Run `rails server -h` for more startup options


========================================
  Your Yarn packages are out of date!
  Please run `yarn install` to update.
========================================


To disable this check, please add `config.webpacker.check_yarn_integrity = false`
to your Rails development config file (config/environments/development.rb).


yarn check v1.5.1
warning Integrity check: Flags don't match
error Integrity check failed
error An unexpected error occurred: "Found 1 errors.".
info If you think this is a bug, please open a bug report with the information provided in "/Users/kurt/Sites/install_test/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.


Exiting

yarn-error.log trace

Trace: 
  Error: Found 1 errors.
      at MessageError.Error (native)
      at new MessageError (/usr/local/Cellar/yarn/1.5.1/libexec/lib/cli.js:186:110)
      at /usr/local/Cellar/yarn/1.5.1/libexec/lib/cli.js:59470:13
      at next (native)
      at step (/usr/local/Cellar/yarn/1.5.1/libexec/lib/cli.js:98:30)
      at /usr/local/Cellar/yarn/1.5.1/libexec/lib/cli.js:109:13

[joeybeninghove]

I'm running into the same thing with a new Rails 5.2 RC2 app. For me it happened when running bundle exec active_storage:install, but it sounds like there is something behind the scenes that multiple things are hitting causing this issue.

Downgrading to 3.3.1 resolves the issue, FYI.

[deepj]

The same problem (rails webpacker:install). Downgrading to 3.3.1 resolved that.

[alopez25]

Hey @joeybeninghove I had the same issue when trying to use Active Storage with Rails 5.2rc2. I've done as suggested downgrading webpacker to 3.3.1. However, I'm getting "Could not find rake-12.3.1 in any of the sources" when trying to run my rails console. Executing bundle install doesn't solve it.
Did it happen to you?

[gauravtiwari]

Thanks everyone, just made a PR

@guilleiguaran We added that production flag earlier on the yarn install task, which raises integrity error after running bundle exec rails assets:precompile in development. By default, yarn respects NODE_ENV so I am not sure if we should consider removing this flag or keep it to ensure deterministic behaviour.

It's a bit unintuitive though, consider this example:

First, when we ran assets:precompile it executed fine but then it installed deps with production flag (using rake yarn install task), which changed the integrity and when we ran rails server again it threw integrity error.

What do you think?

[gauravtiwari]

Just released 3.4.1 ^^

[afuno]

@gauravtiwari Nope. Did not help. It appears when I want to create a model:

rails g model TestModel

Output:

========================================
  Your Yarn packages are out of date!
  Please run `yarn install` to update.
========================================


To disable this check, please add `config.webpacker.check_yarn_integrity = false`
to your Rails development config file (config/environments/development.rb).


env: node: No such file or directory

[gauravtiwari]

@afuno Could you please run yarn just to make sure yarn is run in development mode and then create model?

BTW, this is still an issue: #1374 (comment)
so if you do assets:precompile make sure to run yarn again to re-install deps.

[puneetpandey]

I am facing the same issue. Can someone please suggest what am I doing wrong here!

Ruby 4.2.3
Rails 5.1.5
Webpacker 3.2.2
Hosted on: Elastic Beanstalk
yarn --version ~> 1.5.1
node --version ~> 6.13.1
RAILS_ENV ~> development

Output of /var/log/eb-commandprocessor.log

`/home/webapp` is not a directory.
Bundler will use `/tmp/bundler/home/webapp' as your home directory temporarily.
+ '[' false == true ']'
+ su -s /bin/bash -c 'bundle exec rake assets:precompile' webapp
`/home/webapp` is not a directory.
Bundler will use `/tmp/bundler/home/webapp' as your home directory temporarily.


========================================
  Your Yarn packages are out of date!
  Please run `yarn install` to update.
========================================


To disable this check, please add `config.webpacker.check_yarn_integrity = false`
to your Rails development config file (config/environments/development.rb).


yarn check v1.5.1
warning Skipping preferred cache folder "/home/webapp/.cache/yarn" because it is not writable.
warning Selected the next writable cache folder in the list, will be "/tmp/.yarn-cache-497".
error Couldn't find an integrity file
error An unexpected error occurred: "Found 1 errors.".
info If you think this is a bug, please open a bug report with the information provided in "/var/app/ondeck/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.

(Executor::NonZeroExitStatus)

[2018-03-26T12:37:38.806Z] ERROR [6562]  : Command CMD-SelfStartup failed!
[2018-03-26T12:37:38.806Z] INFO  [6562]  : Command processor returning results: 
{"status":"FAILURE","api_version":"1.0","results":[{"status":"FAILURE","msg":"(TRUNCATED)...nexpected error occurred: \"Found 1 errors.\".\ninfo If you think this is a bug, please open a bug report with the information provided in \"/var/app/ondeck/yarn-error.log\".\ninfo Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command. \nHook 
/opt/elasticbeanstalk/hooks/appdeploy/pre/11_asset_compilation.sh failed. For more detail, check 
/var/log/eb-activity.log using console or EB CLI","returncode":1,"events":[]}],"truncated":"true"}
[2018-03-26T12:37:38.807Z] ERROR [6562]  : exit (SystemExit)
at /opt/elasticbeanstalk/lib/ruby/lib/ruby/gems/2.2.0/gems/beanstalk-core-2.11/bin/command-processor:48:in `exit'
from /opt/elasticbeanstalk/lib/ruby/lib/ruby/gems/2.2.0/gems/beanstalk-core-2.11/bin/command-processor:48:in `<top (required)>'
from /opt/elasticbeanstalk/lib/ruby/bin/command-processor:23:in `load'
from /opt/elasticbeanstalk/lib/ruby/bin/command-processor:23:in `<main>'

Output of /var/app/ondeck/yarn-error.log

Trace: 
  Error: Found 1 errors.
    at MessageError.Error (native)
    at new MessageError (/usr/share/yarn/lib/cli.js:186:110)
    at /usr/share/yarn/lib/cli.js:59470:13
    at next (native)
    at step (/usr/share/yarn/lib/cli.js:98:30)
    at /usr/share/yarn/lib/cli.js:109:13

[gauravtiwari]

@puneetpandey Have you run yarn install as suggested in the error? Does the error go away after that?

[puneetpandey]

@gauravtiwari tried running yarn install manually from /var/app/ondeck and it ran successfully.

ondeck]$ yarn install
yarn install v1.5.1
[1/4] Resolving packages...
success Already up-to-date.
Done in 26.86s.