Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install some npm libraries as devDependencies #1208

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Jan 23, 2018

Hello maintainers.

When I tried to use some installers, I found that some of npm libraries which should locate in devDependencies are in dependencies section in package.json.

So I just tweaked the installation scripts.

@javan
Copy link
Contributor

javan commented Jan 23, 2018

I believe these are needed as dependencies for compiling on the server (aka deploying).

@gauravtiwari
Copy link
Member

Thanks @javan

Yeah, please see this PR #117 and related issue for more info.

@gauravtiwari
Copy link
Member

gauravtiwari commented Jan 23, 2018

Ahh I think elm-hot-loader can be under devDepencies so if you wanna update the PR with only that change I am happy to merge, thank you 👍

@gauravtiwari gauravtiwari reopened this Jan 23, 2018
@ohbarye
Copy link
Contributor Author

ohbarye commented Jan 23, 2018

@javan @gauravtiwari
I didn't know the background and now understand that so let me close this.

Ahh I think elm-hot-loader can be under devDepencies so if you wanna update the PR with only that change I am happy to merge, thank you 👍

elm-hot-loader has originally been under devDependencies. So I have nothing to do for that. 😅

https://github.com/rails/webpacker/pull/1208/files#diff-70f863ebe5733123329d857ce42200ebL25

Thank both of you!

@ohbarye ohbarye closed this Jan 23, 2018
@ohbarye ohbarye deleted the some-npm-libraries-should-be-in-devDependencies branch May 29, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants