Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "webpacker:yarn_install" task env aware #1331

Merged
merged 4 commits into from
Dec 3, 2018
Merged

Make "webpacker:yarn_install" task env aware #1331

merged 4 commits into from
Dec 3, 2018

Commits on Dec 3, 2018

  1. Make webpacker:yarn_install task env aware 

    When webpacker compiles in a non-production environment it's removing
node_modules which are dev dependencies. This is problematic on CI for
example because these dependencies may be required.
    @odlp
    Oli Peate authored and odlp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    b11895e View commit details
    Browse the repository at this point in the history

  2. Use alternative to Bundler.with_clean_env 

    This was failing on CI presumably because BUNDLE_GEMFILE was being
lost, causing the 4.2.x Gemfile tests to fail.
    @odlp
    Oli Peate authored and odlp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    c5e633f View commit details
    Browse the repository at this point in the history

  3. Remove explicit production flag from Yarn Install task 

    If the NODE_ENV is set then Yarn will behave accordingly (e.g. skip
devDependencies if NODE_ENV=production).

Based on discussion:
#1331 (comment)
    @odlp
    odlp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    fe7e571 View commit details
    Browse the repository at this point in the history

  4. Use existing with_node_env helper

    @odlp
    odlp committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    265ae15 View commit details
    Browse the repository at this point in the history