Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add resolved paths to app-code babel compile #1946

Merged
merged 1 commit into from Feb 27, 2019

Conversation

maschwenk
Copy link
Contributor

@maschwenk maschwenk commented Feb 14, 2019

After we split the node_module compiling from the app code compiling, we left out resolved_paths. I first noticed this after I upgraded to v4.0.0.rc.3 from v4.0.0.rc.2.

This commit has now created the whitelist of node_module compiled code, which left my resolved_paths out of the loop (neither compiled by accident by the old node_module config, nor compiled by the babel config because it only looks at the source_path)

For people providing resolved_paths != []

I realize not every project is using resolved_paths but without this you get very confusing errors if your source_path code is depending on resolved_path code. I think whatever performance penalty you get from this should be expected given it's clearly stated that resolved_paths are not-ideal elsewhere.

It's hard to imagine this would be unexpected/unwanted for people specifying resolved_paths because it was probably happening in Webpacker 3.x anyway

For people providing resolved_paths === []

For people not using resolved_paths this will have no effect.

@javan javan merged commit e5deb13 into rails:master Feb 27, 2019
@javan
Copy link
Contributor

javan commented Feb 27, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants