Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry with @babel/polyfill upgrade instructions #2107

Merged
merged 1 commit into from
May 28, 2019
Merged

Add changelog entry with @babel/polyfill upgrade instructions #2107

merged 1 commit into from
May 28, 2019

Conversation

jakeNiemiec
Copy link
Member

@jakeNiemiec jakeNiemiec commented May 28, 2019

Taking @connorshea's suggestion from #2031 (comment) to warn users who were using @babel/polyfill. With #2031 merged, users who upgrade will need to remove import '@babel/polyfill' from their pack files and add the replacements to those files and their package.json.

Taking @connorshea's suggestion from #2031 (comment) to warn users who were using `@babel/polyfill`
@jakeNiemiec jakeNiemiec changed the title WIP Add changelog entry with upgrade guide. Add changelog entry with upgrade guide. May 28, 2019
@jakeNiemiec jakeNiemiec changed the title Add changelog entry with upgrade guide. Add changelog entry with @babel/polyfill upgrade instructions May 28, 2019
@gauravtiwari gauravtiwari merged commit 80f3b55 into rails:master May 28, 2019
@jaredbeck
Copy link
Contributor

jaredbeck commented May 28, 2019

In each of your /packs/*.js files, change this:
import "@babel/polyfill";

What if we don't have such an import? Should we still add the new imports?

@PikachuEXE
Copy link

If you use polyfill differently you can skip it
My project use feature detection and only load polyfill chunk if any feature missing

@jakeNiemiec jakeNiemiec deleted the patch-1 branch May 29, 2019 14:28
@jakeNiemiec
Copy link
Member Author

I would add the new imports, the docs say that the new imports can handle both core-js 2 & 3 https://babeljs.io/blog/2019/03/19/7.4.0#migration-from-core-js-2.

It's hard to make a general recommendation since all of this depends on how you use babel.config.js. I expect issues to pop up, babel has always been that tool that you forget about until it stops working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants