Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract CSS and have smaller build size. #310

Merged
merged 2 commits into from May 1, 2017
Merged

Extract CSS and have smaller build size. #310

merged 2 commits into from May 1, 2017

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented May 1, 2017

Extracting CSS into a Single File vue-loader.

This gets us ~7,6K smaller build, because we don 't need JS to inject styles into head during runtime.

Comparison:

Before:
css-injected-into-head

After:
extracted-css-file

@gauravtiwari gauravtiwari merged commit c50699a into rails:master May 1, 2017
@gauravtiwari
Copy link
Member

Great thanks 👍

@zigomir zigomir deleted the vue-extract-styles branch May 1, 2017 14:31
@morr morr mentioned this pull request May 7, 2017
Closed
@inopinatus inopinatus mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zigomir @gauravtiwari