Add fast refresh to default babel if packages exist #3220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already check for React in the bable config, let's do the right thing if the package for fast-refresh is installed.
justin808
force-pushed
the
justin808/add-fast-refresh-to-default-babel
branch
from
5df9305
to
7dc5cf4
Compare
|
I'm not sure this should be in the code because it seems to be really tight to React and I think Webpacker should not add framework related code in its own codebase. What do you think? |
|
I added because we have other React code: webpacker/package/babel/preset.js Line 36 in 06dcf5f So we might as well support HMR if we're going to support React. Or we should remove React. I think it's fine to support React by checking if the packages are installed. "It just works" |
|
As discussed, we should close this PR for #3224 right? 👍 |
|
@justin808 Should be close this PR? |
|
Sure. Let's close it. I think we should merge #3224. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it's extremely easy to make React work with HMR.
Here's a PR in my example project demonstrating the improvement:
shakacode/react_on_rails_demo_ssr_hmr#20