Backport #3250 to 5-x-stable branch #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Dir.exists?` and `File.exists? were removed by ruby/ruby#5352. It will be the following error in Ruby 3.2. ```console % ruby -ve 'File.exists?("foo.rb")' ruby 3.2.0dev (2021-12-28T15:22:18Z master 39b3aa4fb3) [x86_64-darwin19] -e:1:in `<main>': undefined method `exists?' for File:Class (NoMethodError) File.exists?("foo.rb") ^^^^^^^^ Did you mean? exist? ``` And this PR enables `Lint/DeprecatedClassMethods` cop to detect these deprecated methods.
|
💯 would appreciate this to be done soon. |
|
@byroot Thank you for working on this! |
|
Thanks for letting me know. Unfortunately I don't have an NPM account, hence not the ownership of the package. I relayed the issue to rails-core. |
|
@dhh released the 5.4.4 a few minutes ago: https://www.npmjs.com/package/@rails/webpacker so you should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently released stable version of webpacker (5.4.3) does not work on the newest stable Ruby (3.2.0) because webpacker 5.4.3 includes
Dir.exists?andFile.exists?that were removed in Ruby 3.2.Hence, the current situation is that Rails 6.1 users cannot upgrade to Ruby 3.2 because there's no webpacker that supports that versions stack. We could solve this situation by backporting a single commit from #3250.
Please consider merging this and cutting the version 5.4.4 release from 5-x-stable branch. Then probably people would stop complaining to the Ruby-core on the Ruby BTS about this error from webpacker... https://bugs.ruby-lang.org/issues/19352
Closes #3299