Issue 464 merge webpacker lite into webpacker v2 #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acker-lite-into-webpacker-v2 * upstream/hmr: Make linter happy Fix typo Update readme and changelog Update condition for extracting CSS Remove redundant variables Update sass loader and remove redundant config from vue loader Fix development.js changes Add HMR
…acker-lite-into-webpacker-v2 * upstream/hmr: Only configure the dev server in the dev environment #642 Add Troubleshooting Item for invalid config (#643)
…ebpacker-lite-into-webpacker-v2 * upstream/master: Update React pointers to include react on rails
This fix addresses the cases where compile is disabled: 1. If React on Rails depends on Webpacker, but the React on Rails installer has not yet generated a webpacker.yml file or a React on Rails installation is not using Webpacker, then the gem loading of Webpacker will crash due to the missing config file. 2. If React on Rails has its own helper to compile assets for tests, then the manifest might need to get reloaded after Webpacker statically loads.
|
The following changed in React on Rails: https://github.com/shakacode/react_on_rails/pull/908/files You can find this as https://rubygems.org/gems/react_on_rails/versions/9.0.0.beta.7 |
|
See #656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the HMR changes as well as the following commit.
This fix addresses the cases where compile is disabled:
If React on Rails depends on Webpacker, but the React on Rails
installer has not yet generated a webpacker.yml file or a React on Rails
installation is not using Webpacker, then the gem loading of Webpacker
will crash due to the missing config file.
If React on Rails has its own helper to compile assets for tests,
then the manifest might need to get reloaded after Webpacker statically
loads.
Relevant change:
7abcc21