Skip to content

Commit

Permalink
Drop Refile support due to inactivity
Browse files Browse the repository at this point in the history
  • Loading branch information
mshibuya committed Jul 14, 2019
1 parent 876b364 commit 25ae06a
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 99 deletions.
1 change: 0 additions & 1 deletion lib/rails_admin/config/fields.rb
Expand Up @@ -82,7 +82,6 @@ def self.register_factory(&block)
require 'rails_admin/config/fields/factories/paperclip'
require 'rails_admin/config/fields/factories/dragonfly'
require 'rails_admin/config/fields/factories/carrierwave'
require 'rails_admin/config/fields/factories/refile'
require 'rails_admin/config/fields/factories/active_storage'
require 'rails_admin/config/fields/factories/shrine'
require 'rails_admin/config/fields/factories/action_text'
Expand Down
25 changes: 0 additions & 25 deletions lib/rails_admin/config/fields/factories/refile.rb

This file was deleted.

1 change: 0 additions & 1 deletion lib/rails_admin/config/fields/types/all.rb
Expand Up @@ -12,7 +12,6 @@
require 'rails_admin/config/fields/types/file_upload'
require 'rails_admin/config/fields/types/paperclip'
require 'rails_admin/config/fields/types/carrierwave'
require 'rails_admin/config/fields/types/refile'
require 'rails_admin/config/fields/types/multiple_file_upload'
require 'rails_admin/config/fields/types/multiple_active_storage'
require 'rails_admin/config/fields/types/multiple_carrierwave'
Expand Down
27 changes: 0 additions & 27 deletions lib/rails_admin/config/fields/types/refile.rb

This file was deleted.

7 changes: 2 additions & 5 deletions spec/controllers/rails_admin/main_controller_spec.rb
Expand Up @@ -329,7 +329,6 @@ def get(action, params)
field :paperclip_asset do
delete_method :delete_paperclip_asset
end
field :refile_asset if defined?(Refile)
field :active_storage_asset do
delete_method :remove_active_storage_asset
end if defined?(ActiveStorage)
Expand All @@ -352,8 +351,7 @@ def get(action, params)
'paperclip_asset' => 'test',
'delete_paperclip_asset' => 'test',
'should_not_be_here' => 'test',
}.merge(defined?(Refile) ? {'refile_asset' => 'test', 'remove_refile_asset' => 'test'} : {}).
merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
}.merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
merge(defined?(Shrine) ? {'shrine_asset' => 'test', 'remove_shrine_asset' => 'test'} : {}),
)

Expand All @@ -368,8 +366,7 @@ def get(action, params)
'retained_dragonfly_asset' => 'test',
'paperclip_asset' => 'test',
'delete_paperclip_asset' => 'test',
}.merge(defined?(Refile) ? {'refile_asset' => 'test', 'remove_refile_asset' => 'test'} : {}).
merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
}.merge(defined?(ActiveStorage) ? {'active_storage_asset' => 'test', 'remove_active_storage_asset' => 'test', 'active_storage_assets' => 'test', 'remove_active_storage_assets' => 'test'} : {}).
merge(defined?(Shrine) ? {'shrine_asset' => 'test', 'remove_shrine_asset' => 'test'} : {}))
end

Expand Down
6 changes: 0 additions & 6 deletions spec/dummy_app/Gemfile
Expand Up @@ -27,7 +27,6 @@ group :mongoid do
gem 'kaminari-mongoid'
gem 'mongoid-paperclip', '>= 0.0.8', require: 'mongoid_paperclip'
gem 'carrierwave-mongoid', '>= 0.6.3', require: 'carrierwave/mongoid'
# gem 'refile-mongoid', '>= 0.0.1', platforms: [:ruby_21, :ruby_22]
gem 'shrine-mongoid'
end

Expand All @@ -41,11 +40,6 @@ gem 'rails_admin', path: '../../'
gem 'shrine', '~> 2.0'
gem 'shrine-memory'

platforms :mri do
# gem 'refile', '>= 0.5', require: 'refile/rails'
# gem 'refile-mini_magick', '>= 0.1.0'
end

# Gems used only for assets and not required
# in production environments by default.
group :assets do
Expand Down
2 changes: 0 additions & 2 deletions spec/dummy_app/app/active_record/field_test.rb
Expand Up @@ -17,8 +17,6 @@ class FieldTest < ActiveRecord::Base
mount_uploaders :carrierwave_assets, CarrierwaveUploader
serialize :carrierwave_assets, JSON

attachment :refile_asset if defined?(Refile)

if defined?(ActiveStorage)
has_one_attached :active_storage_asset
attr_accessor :remove_active_storage_asset
Expand Down
9 changes: 0 additions & 9 deletions spec/dummy_app/app/mongoid/field_test.rb
Expand Up @@ -62,14 +62,5 @@ class FieldTest
# https://github.com/carrierwaveuploader/carrierwave-mongoid/issues/138
mount_uploader :carrierwave_assets, CarrierwaveUploader

if defined?(Refile)
extend Refile::Mongoid::Attachment

field :refile_asset_filename
field :refile_asset_size
field :refile_asset_content_type
attachment :refile_asset
end

validates :short_text, length: {maximum: 255}
end
21 changes: 0 additions & 21 deletions spec/rails_admin/config/fields/base_spec.rb
Expand Up @@ -177,14 +177,6 @@ class CommentReversed < Tableless
end
end

if defined?(Refile)
context 'of a Refile installation' do
it 'is a _id field' do
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.children_fields).to eq([:refile_asset_id, :refile_asset_filename, :refile_asset_size, :refile_asset_content_type])
end
end
end

if defined?(ActiveStorage)
context 'of a ActiveStorage installation' do
it 'is _attachment and _blob fields' do
Expand Down Expand Up @@ -410,12 +402,6 @@ class CommentReversed < Tableless
it 'of carrierwave should find the underlying column on the base table' do
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.searchable_columns.collect { |c| c[:column] }).to eq(['field_tests.carrierwave_asset'])
end

if defined?(Refile)
it 'of refile should find the underlying column on the base table' do
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.searchable_columns.collect { |c| c[:column] }).to eq(['field_tests.refile_asset_id'])
end
end
end
end

Expand Down Expand Up @@ -447,13 +433,6 @@ class CommentReversed < Tableless
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.searchable).to eq(:carrierwave_asset)
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :carrierwave_asset }.sortable).to eq(:carrierwave_asset)
end

if defined?(Refile)
it 'of refile should target the first children field' do
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.searchable).to eq(:refile_asset_id)
expect(RailsAdmin.config(FieldTest).fields.detect { |f| f.name == :refile_asset }.sortable).to eq(:refile_asset_id)
end
end
end
end

Expand Down
2 changes: 0 additions & 2 deletions spec/rails_admin/config/fields/types/file_upload_spec.rb
Expand Up @@ -12,7 +12,6 @@
field :paperclip_asset do
delete_method :delete_paperclip_asset
end
field :refile_asset
field :active_storage_asset do
delete_method :remove_active_storage_asset
end if defined?(ActiveStorage)
Expand All @@ -25,7 +24,6 @@
expect(RailsAdmin.config(FieldTest).field(:carrierwave_asset).allowed_methods.collect(&:to_s)).to eq %w(carrierwave_asset remove_carrierwave_asset carrierwave_asset_cache)
expect(RailsAdmin.config(FieldTest).field(:dragonfly_asset).allowed_methods.collect(&:to_s)).to eq %w(dragonfly_asset remove_dragonfly_asset retained_dragonfly_asset)
expect(RailsAdmin.config(FieldTest).field(:paperclip_asset).allowed_methods.collect(&:to_s)).to eq %w(paperclip_asset delete_paperclip_asset)
expect(RailsAdmin.config(FieldTest).field(:refile_asset).allowed_methods.collect(&:to_s)).to eq %w(refile_asset remove_refile_asset) if defined?(Refile)
expect(RailsAdmin.config(FieldTest).field(:active_storage_asset).allowed_methods.collect(&:to_s)).to eq %w(active_storage_asset remove_active_storage_asset) if defined?(ActiveStorage)
expect(RailsAdmin.config(FieldTest).field(:shrine_asset).allowed_methods.collect(&:to_s)).to eq %w(shrine_asset remove_shrine_asset cached_shrine_asset_data) if defined?(Shrine)
end
Expand Down

0 comments on commit 25ae06a

Please sign in to comment.