Fix orderable multiselect buttons (#3506)

* add .vscode to gitignore * Change Up/Down multiselect labels to titles Run prettier
railsadminteam · Apr 7, 2022 · e5bb7ba · e5bb7ba
1 parent 42d668f
commit e5bb7ba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,6 +4,7 @@
 *.swp
 .bundle
 .idea/
+.vscode/
 .rvmrc
 .sass-cache
 .yardoc

diff --git a/src/rails_admin/filtering-multiselect.js b/src/rails_admin/filtering-multiselect.js
@@ -1,7 +1,6 @@
 import jQuery from "jquery";
 import "jquery-ui/ui/widget";
 import I18n from "./i18n";
-
 (function ($) {
   $.widget("ra.filteringMultiselect", {
     _cache: {},
@@ -112,15 +111,11 @@ import I18n from "./i18n";
       }
       if (this.options.sortable) {
         this.up = $(
-          '<a href="#" class="fas fa-chevron-circle-up ra-multiselect-item-up">' +
-            this.options.regional.up +
-            "</a>"
-        );
+          '<a href="#" class="fas fa-chevron-circle-up ra-multiselect-item-up"></a>'
+        ).attr("title", this.options.regional.up);
         this.down = $(
-          '<a href="#" class="fas fa-chevron-circle-down ra-multiselect-item-down">' +
-            this.options.regional.down +
-            "</a>"
-        );
+          '<a href="#" class="fas fa-chevron-circle-down ra-multiselect-item-down"></a>'
+        ).attr("title", this.options.regional.down);
         columns.center.append(this.up).append(this.down);
       }