Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1241 #1580

Merged
merged 3 commits into from
Apr 3, 2013
Merged

Issue 1241 #1580

merged 3 commits into from
Apr 3, 2013

Conversation

DarthMax
Copy link
Contributor

Improves Pull Request #1302 because $.attr('checked') does not work for reading checked state of a checkbox.
I think this feature is necessary because for large models (de)selecting all fields needs lots of clicks, even when using the existing feature (clicking on the model/relation name).

@coveralls
Copy link

Coverage decreased (-0.04%) when pulling 1071a0a on DarthMax:issue_1241_fix into 8533e5a on sferik:master.

View Details

@bbenezech
Copy link
Collaborator

Can you please put the JS behavior in the app/assets/javascripts/rails_admin/ui.coffee file ?

@DarthMax
Copy link
Contributor Author

DarthMax commented Apr 2, 2013

Okay I have moved the stuff to ui.coffee ;)

@coveralls
Copy link

Coverage decreased (-0.0%) when pulling 85fe0a4 on DarthMax:issue_1241_fix into 8533e5a on sferik:master.

View Details

@bbenezech
Copy link
Collaborator

Nice, thanks!

bbenezech added a commit that referenced this pull request Apr 3, 2013
@bbenezech bbenezech merged commit bb64c94 into railsadminteam:master Apr 3, 2013
@Napoleonyjl
Copy link

Hi DarthMax , Thanks for the feature!
I would like to make this select/unselect checkbox work for each field(including the associated fields), could you give me a hint to do this?
I tried but failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants