Fix for polymorphic association field selector not working with AR #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich stores and queries the STI base class in polymorphic associations. This commit correctly sets the <polymorphic>_type field to the object's STI base class (not the object's class).
mshibuya
added a commit
that referenced
this pull request
Jun 9, 2019
Fix for polymorphic association field selector not working with AR
mshibuya
added a commit
that referenced
this pull request
Jun 9, 2019
…ype in #parse_input Refs. #2136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AR stores and queries the STI base class in polymorphic associations. This commit correctly sets the _type field to the object's STI base class (not the object's class).
Note: I used the rubygem (0.6.5) version because master (0.6.6) is broken. The cerulean theme has not been updated and gives an error, plus a few other css issues., however you should be able to pull also on top of master