Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refile support #2385

Merged
merged 2 commits into from
Aug 20, 2015
Merged

Conversation

omoshetech-t
Copy link
Contributor

Add support for a modern file upload library. https://github.com/refile/refile

@@ -47,6 +47,9 @@ group :test do
gem 'paperclip', ['>= 3.4', '!= 4.3.0']
gem 'poltergeist', '~> 1.5'
gem 'rack-cache', require: 'rack/cache'
gem 'refile', '>= 0.5.5', require: 'refile/rails'
gem 'refile-mini_magick', '>= 0.1.0'
gem 'refile-mongoid', '>= 0.0.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refile-mongoid should go into :mongoid group, since it is only required for mongoid builds.

@mshibuya
Copy link
Member

CI build is failing, can you investigate?

@omoshetech-t
Copy link
Contributor Author

refile-mongoid should go into :mongoid group, since it is only required for mongoid builds.

I'll fix it.

CI build is failing, can you investigate?

I forgot to check required Ruby version of the refile gem. It needs >= 2.1.0. This is one reason of build failure. So is it difficult to merge this request?

Build failures also occurred when satisfy refile required Ruby version. I can investigate reasons of this failures.

@mshibuya
Copy link
Member

I forgot to check required Ruby version of the refile gem. It needs >= 2.1.0. This is one reason of build failure.

Then you can conditionally install(and test) refile gem for Ruby >= 2.1.0. To merge in, passing all builds is mandatory.

@omoshetech-t
Copy link
Contributor Author

I add conditional statements of Ruby version for build failures fix.

The build failures when satisfy refile required Ruby version, cause sass-rails version.
sass-rails 5.0.0 is installed when I add gem "refile", ">= 0.5.5" to rails_4.2.gemfile, but this project needs sass-rails >= 5.0.2. If I don't add gem "refile", ">= 0.5.5", sass-rails 5.0.3 is installed. This problem doesn't occur bundler version >= 1.9.0.pre. rails_4.0.gemfile and rails_4.1.gemfile also have sass-rails version problem but they are a little different. In this case, sass-rails 4.0.0 is installed.

I cannot investigate detailed reason. However I found a workaround. If I add gem "sass-rails", "~> 5.0" and gem "refile", "~> 0.5" to Gemfile, bundler installs the correct version of sass-rails.

Then all tests have been passed now.

mshibuya added a commit that referenced this pull request Aug 20, 2015
@mshibuya mshibuya merged commit 88eb9c3 into railsadminteam:master Aug 20, 2015
@mshibuya
Copy link
Member

Merged in, thanks 🙆‍♀️

mshibuya added a commit that referenced this pull request Aug 20, 2015
mshibuya added a commit that referenced this pull request Aug 20, 2015
Conditionally executed code in #2385 decreases coverage so much 😵
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants