Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the dependency version of Haml #2840

Merged
merged 2 commits into from
Feb 28, 2017

Conversation

koic
Copy link
Contributor

@koic koic commented Feb 27, 2017

Haml 5.0.0.beta.2 is out.

This version will bring 3x rendering speed-up.

And, this PR suppress the following warning associated with upgrading.

Haml::TempleEngine: Option :ugly is invalid

Refer: haml/haml#894

I'd like to use it as soon as possible.

Thanks.

@mshibuya mshibuya merged commit 46cd7ec into railsadminteam:master Feb 28, 2017
@mshibuya
Copy link
Member

Thanks!

@koic koic deleted the loosen_dependency_haml branch February 28, 2017 02:06
@koic
Copy link
Contributor Author

koic commented Feb 28, 2017

Thanks for your merging! I'm looking forward to the release.

@vincentwoo
Copy link
Contributor

Releasing this change becomes a lot more important with the advent of Rails 5.1 and the deprecation of Erubis. The next release of Haml will likely be able to switch to Erubi and thus make rails_admin compatible with Rails 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants