Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use value instead url in file's link_to body #2983

Closed
wants to merge 1 commit into from

Conversation

buncis
Copy link
Contributor

@buncis buncis commented Jan 18, 2018

use filename/value instead full url in file's link_to body

@mshibuya
Copy link
Member

mshibuya commented May 4, 2018

Could you write a spec for this?

@buncis
Copy link
Contributor Author

buncis commented May 4, 2018

@mshibuya I want to write the spec, but I don't know how since it have no spec before, can you guide me how to write the spec? thank you

  describe '#pretty_value' do
    it 'use value instead url for link_to body' do
      expect().to eq value
    end
  end

@mshibuya
Copy link
Member

Cherry-picked as e3770ba.

@mshibuya mshibuya closed this Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants