Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bulk delete shows error flash message on successful delete #3022

Closed
wants to merge 1 commit into from
Closed

Fix for bulk delete shows error flash message on successful delete #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 5 additions & 9 deletions lib/rails_admin/config/actions/bulk_delete.rb
View file
Open in desktop
Expand Up @@ -26,26 +26,22 @@ class BulkDelete < RailsAdmin::Config::Actions::Base

elsif request.delete? # BULK DESTROY

destroyed = nil
not_destroyed = nil
destroyed_objects = nil

unless params[:bulk_ids].blank?
@objects = list_entries(@model_config, :destroy)
unless @objects.blank?
processed_objects = @abstract_model.destroy(@objects)
destroyed = processed_objects.select(&:destroyed?)
not_destroyed = processed_objects - destroyed
destroyed.each do |object|
destroyed_objects = @abstract_model.destroy(@objects)
destroyed_objects.each do |object|
@auditing_adapter && @auditing_adapter.delete_object(object, @abstract_model, _current_user)
end
end
end

if destroyed.nil?
if destroyed_objects.blank?
flash[:error] = t('admin.flash.error', name: pluralize(0, @model_config.label), action: t('admin.actions.delete.done'))
else
flash[:success] = t('admin.flash.successful', name: pluralize(destroyed.count, @model_config.label), action: t('admin.actions.delete.done')) unless destroyed.empty?
flash[:error] = t('admin.flash.error', name: pluralize(not_destroyed.count, @model_config.label), action: t('admin.actions.delete.done')) unless not_destroyed.empty?
flash[:success] = t('admin.flash.successful', name: pluralize(destroyed_objects.count, @model_config.label), action: t('admin.actions.delete.done'))
end
redirect_to back_or_index
end
Expand Down