code_reload #3041
Merged
code_reload #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, can you make CI pass? |
AnatolyShirykalov
force-pushed
the
code_reload
branch
4 times, most recently
from
55a9ee3
to
de8dab4
Compare
AnatolyShirykalov
force-pushed
the
code_reload
branch
from
de8dab4
to
347f145
Compare
|
@mshibuya done |
|
Great, thanks! |
mshibuya
added a commit
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix reloading models when code changes. The problem is connected with pull request #2999
There the problem was solved partially. It fixed the "can't modify frozen array" exception on reload, but versions of models were still old.