Hide present / blank filter options for required fields #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Merged
For cases where a field or association is required (via validations, model config, or otherwise) and is filterable, the associated filter dropdown includes 'present' and 'blank' options that are unnecessary as the field/association is always expected to be present.
codealchemy
force-pushed
the
hide-irrelevant-filter-options
branch
from
f4f980b
to
0033327
Compare
|
Nice, thanks! |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For cases where a field is required (via validations, model config, or otherwise) and filterable, the associated filter dropdown includes
presentandblankoptions that are unnecessary as the field is always expected to be present.Proposed change
Pass the
requiredfield from the model through to the filter box javascript, keeping the existing order but only appending thepresentandblankoptions when the field is not required.📝 I'm not sure how to best test the
jschanges aside from the tests added toindex_spec.rb(which put it over therubocopTODO limit, so I added that file as an exception instead of bumping the max any further).Example using the spec
dummy_appRequired field (
name)Optional field (
team)