Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaperTrail extension updates #3375

Merged
merged 5 commits into from
Aug 14, 2021
Merged

PaperTrail extension updates #3375

merged 5 commits into from
Aug 14, 2021

Commits on Aug 9, 2021

  1. Update PaperTrail version 

    PaperTrail compatibility notes that `v12.x` is the only version supported by Ruby 2.5.
    @codealchemy
    codealchemy committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    4dc17f0 View commit details
    Browse the repository at this point in the history

  2. Fix history#index for models with custom version classes 

    [Starting in `v10.1.0`](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md#deprecated-1), PaperTrail updated the configuration for defining a custom version class for a model.

In RailsAdmin, this impacts the `history#index` view - as the PaperTrail adapter will use the fallback `@version_class` and fail to render the appropriate versions for a configured model.
    @codealchemy
    codealchemy committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    ed19f9e View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary PaperTrail V10 version checks

    @codealchemy
    codealchemy committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    b7c4d51 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Update spec for PaperTrail custom association 

    The custom version class is typically set in an initializer, kept with `PaperTrailTestWithCustomAssociation` here for visibility.
    @codealchemy
    codealchemy committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    a3b9e82 View commit details
    Browse the repository at this point in the history

  2. Update migration for compatibility with older Rails versions 

    Aligning with the version used in the existing `versions` table migration to allow for this migration / related tests to be used in the 2.x stable branch (that supports older Rails versions)
    @codealchemy
    codealchemy committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    be08e01 View commit details
    Browse the repository at this point in the history