Update file upload translations to avoid concatenation #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Sep 11, 2021
mshibuya
reviewed
Sep 11, 2021
codealchemy
force-pushed
the
i18n-key-fix
branch
from
58ccb47
to
2916193
Compare
mshibuya
reviewed
Sep 12, 2021
Following i18n best practices (many covered in https://phrase.com/blog/posts/rails-i18n-best-practices/ - Rails docs: https://guides.rubyonrails.org/i18n.html#passing-variables-to-translations)
codealchemy
force-pushed
the
i18n-key-fix
branch
from
2916193
to
54ad6ab
Compare
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the file upload form translations to better align with i18n conventions (ie. avoid concatenating translations).
Closes #3260