Fix bug with MainController#bulk_action #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
reviewed
Oct 30, 2021
| @@ -25,7 +25,7 @@ def #{action.action_name} | |||
| end | |||
|
|
|||
| def bulk_action | |||
| send(params[:bulk_action]) if params[:bulk_action].in?(RailsAdmin::Config::Actions.all(controller: self, abstract_model: @abstract_model).select(&:bulkable?).collect(&:route_fragment)) | |||
| send(params[:bulk_action]) if params[:bulk_action].in?(RailsAdmin::Config::Actions.all(:bulkable, controller: self, abstract_model: @abstract_model).select(&:bulkable?).collect(&:route_fragment)) | |||
There was a problem hiding this comment.
.select(&:bulkable?) is no longer necessary, right?
|
Could you add a test for this fix? |
Pull Request Test Coverage Report for Build 1732499667
💛 - Coveralls |
|
This shouldn't be considered as the fix for issue #3404 (just happens to go around it in your setup), but the fix itself makes sense. |
mshibuya
added a commit
that referenced
this pull request
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For checking if action exists, was used
:allscope instead of:bulkable. Because of this, will-called all policy methods which possibly can raise some errors