Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nearly all jQuery from ra.sidescroll.js #3416

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

jdufresne
Copy link
Member

All DOM methods now use native browser features.

The only remaining jQuery is used to listen to the custom jQuery event
"rails_admin.dom_ready".

Refs #2893

@jdufresne jdufresne force-pushed the sidescroll branch 2 times, most recently from ed1ad65 to 0e02caa Compare November 14, 2021 17:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1459412251

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.09%) to 93.753%

Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 4 91.11%
Totals Coverage Status
Change from base Build 1415561078: -2.09%
Covered Lines: 3377
Relevant Lines: 3602

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 14, 2021

Pull Request Test Coverage Report for Build 1483588941

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.76%

Totals Coverage Status
Change from base Build 1474499195: 0.1%
Covered Lines: 3636
Relevant Lines: 3797

💛 - Coveralls

All DOM methods now use native browser features.

The only remaining jQuery is used to listen to the custom jQuery event
"rails_admin.dom_ready".

Refs railsadminteam#2893
@mshibuya mshibuya merged commit 597568e into railsadminteam:master Nov 20, 2021
@mshibuya
Copy link
Member

Thanks!

@jdufresne jdufresne deleted the sidescroll branch November 20, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants