Switch templates from HAML to ERB #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make RailsAdmin have fewer dependencies and so slightly reduce total installation size. Align the project with default upstream Rails practices. Starting a new Rails project includes ERB by default but not HAML. By switching, we don't pull in additional templating practices beyond what any default project is already using. The change may also help encourage contributors. While nearly all Rails developers have direct experience working with ERB, the same is not always true of HAML. This removes a small barrier. Fixes railsadminteam#3173
Pull Request Test Coverage Report for Build 1488133674
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1488133674
💛 - Coveralls |
|
Let's go with this, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make RailsAdmin have fewer dependencies and so slightly reduce total
installation size.
Align the project with default upstream Rails practices. Starting a new
Rails project includes ERB by default but not HAML. By switching, we
don't pull in additional templating practices beyond what any default
project is already using.
The change may also help encourage contributors. While nearly all Rails
developers have direct experience working with ERB, the same is not
always true of HAML. This removes a small barrier.
Fixes #3173