Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable rubocop-performance #3434

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Enable rubocop-performance #3434

merged 1 commit into from
Nov 30, 2021

Conversation

jdufresne
Copy link
Member

The gem was included in the Gemfile, just not enabled in the RuboCop
configuration.

@jdufresne
Enable rubocop-performance
737fd15 
The gem was included in the Gemfile, just not enabled in the RuboCop
configuration.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1513902310

  • -2 of 4 (50.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-4.9%) to 90.996%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/rails_admin/adapters/mongoid.rb 0 1 0.0%
lib/rails_admin/config/fields/types/color.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 1 97.78%
Totals Coverage Status
Change from base Build 1512343422: -4.9%
Covered Lines: 3345
Relevant Lines: 3676
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 29, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1513902310

  • 2 of 4 (50.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 95.864%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/rails_admin/adapters/mongoid.rb 0 1 0.0%
lib/rails_admin/config/fields/types/color.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 1 97.78%
Totals Coverage Status
Change from base Build 1512343422: -0.03%
Covered Lines: 3616
Relevant Lines: 3772
💛 - Coveralls

@mshibuya mshibuya merged commit c7f907c into railsadminteam:master Nov 30, 2021
@mshibuya
Copy link
Member

Great finding!

@jdufresne jdufresne deleted the perf branch November 30, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdufresne @coveralls @mshibuya