Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JavaScript library jquery-pjax #3435

Closed
wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Member

The library is no longer maintained and has not received a new release
since May 20, 2017. See https://github.com/defunkt/jquery-pjax

Status of this project

jquery-pjax is largely unmaintained at this point.

This also removes the Ruby gem rack-pjax which is also no longer
maintained and has not received a new release since Mar 24, 2019.

This is work towards the goal of dropping jQuery in favor of more
vanilla JavaScript solutions. As a dependency using jQuery, pjax was a
barrier toward this goal.

jquery-pjax was originally introduced in
645d678 (Nov 16, 2011). Presumably as a
page loading optimization, however it is not strictly necessary to
achieve the set of RailsAdmin features. After many years of improvements
in browser caching, loading, and JavaScript evaluation it is unclear if
this optimization is still necessary for a good UX.

Refs #2893

The library is no longer maintained and has not received a new release
since May 20, 2017. See https://github.com/defunkt/jquery-pjax

> Status of this project
>
> jquery-pjax is largely unmaintained at this point.

This also removes the Ruby gem rack-pjax which is also no longer
maintained and has not received a new release since Mar 24, 2019.

This is work towards the goal of dropping jQuery in favor of more
vanilla JavaScript solutions. As a dependency using jQuery, pjax was a
barrier toward this goal.

jquery-pjax was originally introduced in
645d678 (Nov 16, 2011). Presumably as a
page loading optimization, however it is not strictly necessary to
achieve the set of RailsAdmin features. After many years of improvements
in browser caching, loading, and JavaScript evaluation it is unclear if
this optimization is still necessary for a good UX.

Refs railsadminteam#2893
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1514239307

  • 0 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.2%) to 93.658%

Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 1 97.78%
Totals Coverage Status
Change from base Build 1512343422: -2.2%
Covered Lines: 3367
Relevant Lines: 3595

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 29, 2021

Coverage Status

Changes unknown
when pulling b095c6f on jdufresne:remove-pjax
into ** on railsadminteam:master**.

@mshibuya
Copy link
Member

mshibuya commented Dec 1, 2021

it is unclear if this optimization is still necessary for a good UX

This is understandable, but I'm not totally sure about it. It would be ideal if we can perform quantitative comparison...

Another solution will be migrating to Turbo Drive, which I understand is modernized version of Pjax.

mshibuya added a commit that referenced this pull request Jan 16, 2022
* Remove JavaScript library jquery-pjax

The library is no longer maintained and has not received a new release
since May 20, 2017. See https://github.com/defunkt/jquery-pjax

> Status of this project
>
> jquery-pjax is largely unmaintained at this point.

This also removes the Ruby gem rack-pjax which is also no longer
maintained and has not received a new release since Mar 24, 2019.

This is work towards the goal of dropping jQuery in favor of more
vanilla JavaScript solutions. As a dependency using jQuery, pjax was a
barrier toward this goal.

jquery-pjax was originally introduced in
645d678 (Nov 16, 2011). Presumably as a
page loading optimization, however it is not strictly necessary to
achieve the set of RailsAdmin features. After many years of improvements
in browser caching, loading, and JavaScript evaluation it is unclear if
this optimization is still necessary for a good UX.

Refs #2893
@mshibuya
Copy link
Member

Squash-merged with 44451f2, thanks!

I'll try introducing Turbo Drive later.

@mshibuya mshibuya closed this Jan 16, 2022
@jdufresne jdufresne deleted the remove-pjax branch January 16, 2022 15:24
@mshibuya
Copy link
Member

@jdufresne Sorry I failed to put your credit to the commit when I handled squash merge locally.
It was unintentional and I apologize 🙇

@jdufresne
Copy link
Member Author

No worries at all. Thanks for merging and for Rails admin in general!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants