Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve several RuboCop TODO items #3436

Closed
wants to merge 1 commit into from
Closed

Resolve several RuboCop TODO items #3436

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Member

No description provided.

@jdufresne jdufresne changed the title Resolve several RuboCop TOOD items Resolve several RuboCop TODO items Nov 29, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1514517530

  • -2 of 36 (94.44%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.7%) to 91.239%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/rails_admin/adapters/mongoid.rb 0 1 0.0%
lib/rails_admin/engine.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 1512343422: -4.7%
Covered Lines: 3364
Relevant Lines: 3687
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 29, 2021 •
edited
Loading

Coverage Status

Changes unknown
when pulling 39a5a10 on jdufresne:rubocop-todo
into ** on railsadminteam:master**.

@jdufresne jdufresne closed this Feb 7, 2022
@jdufresne jdufresne deleted the rubocop-todo branch February 7, 2022 01:20
@mshibuya
Copy link
Member

Sorry I couldn't follow this up, I lost the timing to merge because of conflicts 🙇

@mshibuya mshibuya mentioned this pull request Feb 19, 2022
Open
@jdufresne
Copy link
Member Author

No problem. I reopened as #3478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdufresne @coveralls @mshibuya