VotesController (not VotesControllerTest) should inherit from ApplicationController #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2011 00:32
ApplicationController
button not a link. and because a button is more appropriate for a state change on the server.
|
FYI, on commit ece7e09 -- I changed only "+1" link, not the "Delete" link because there would be more code to continue to have the "Are you sure?" confirmation dialog and that seems like too much. but this is an easy change and its appropriate for a state change. and its more fun to click! |
alexch
added a commit
that referenced
this pull request
Nov 19, 2011
VotesController (not VotesControllerTest) should inherit from ApplicationController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.