New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authentication (user accounts) with Devise #276

Merged
merged 2 commits into from Apr 3, 2016

Conversation

Projects
None yet
2 participants
@blossomica
Contributor

blossomica commented Apr 2, 2016

Hello I noticed that the URL here does not work due to the trailing slash. I tried to fix it by omitting it.
Please check it and let me know if you need any alternation or me to merge both commits into one.
Thank you.

blossomica added some commits Apr 2, 2016

Add Authentication (user accounts) with Devise
The URL seems to give 404 due to the trailing space.
Merge pull request #1 from blossomica/devise-fix
Add Authentication (user accounts) with Devise
@vesan

This comment has been minimized.

Member

vesan commented Apr 3, 2016

@blossomica It seems to work: http://guides.railsgirls.com/devise Where did you see it not working?

@blossomica

This comment has been minimized.

Contributor

blossomica commented Apr 3, 2016

@vesan - Here: http://guides.railsgirls.com/app when you go to the end and click Guide number 5, the url there is broken. The guide exists and works as you said but the URL seems to not be pointing to it correctly due to the trailing slash.

@vesan

This comment has been minimized.

Member

vesan commented Apr 3, 2016

Oh, you are right. I misread the diff.

Thanks for fixing it!

@vesan vesan merged commit 8a4fce0 into railsgirls:master Apr 3, 2016

@blossomica

This comment has been minimized.

Contributor

blossomica commented Apr 3, 2016

@vesan - You are welcome :) It is my pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment