Fix "config.enabled" not working #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhajrahmoun
commented
Apr 24, 2024
| @@ -1,7 +1,11 @@ | |||
| module RailsLiveReload | |||
| class Railtie < ::Rails::Engine | |||
| if RailsLiveReload.enabled? && (defined?(::Rails::Server) || ENV['SERVER_PROCESS']) | |||
| initializer "rails_live_reload.middleware" do |app| | |||
| def enabled? | |||
There was a problem hiding this comment.
enabled can probably be changed into something more meaningful. Open to suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #26.
The
RailsLiveReload.enabled?check is currently performed immediately when the Railtie class is interpreted, returningtruesince it's the default value. However, due to the Rails application lifecycle, the state ofRailsLiveReload.enabled?will change by the time the initializers are run and it will return the value specified in the rails app initializer.I tried moving the
RailsLiveReload.enabled?check into each initializer block and it seems to be fixing the issue.