Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse statement numbers correctly based on specs #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parse statement numbers correctly based on specs #53

wants to merge 1 commit into from

Conversation

hapm
Copy link

@hapm hapm commented Apr 1, 2021

The statement number regular expression is changed to allow statement numbers without leading zeros and statement numbers with missing sequence number. This fixes #52

@bumi
Copy link
Contributor

bumi commented Apr 1, 2021

thanks for the PR. looks good to me.

does anybody else have a review?

@bumi
Copy link
Contributor

bumi commented Apr 23, 2021

@Uepsilon or @kangguru you want to have a look. it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statement and sequence numbers aren't correctly parsed when without filling 0 digits
2 participants
@hapm @bumi