Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137: Accepting all passed attributes for google_global tracking #138

Merged
merged 2 commits into from Jul 11, 2019

Conversation

marisveide
Copy link
Contributor

As agreed in #137 - made the change which will pass all the given attributes to the gtag.
It will only skip the action attribute, as that is used as a second argument already.

Please, would be awesome if you can merge this.

Thanks!

@bumi bumi merged commit 781f7cd into railslove:master Jul 11, 2019
@bumi
Copy link
Contributor

bumi commented Jul 11, 2019

thanks for the contribution! will be included in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants