Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route Globbing #37

Closed
erikreedstrom opened this issue Mar 13, 2012 · 2 comments
Closed

Route Globbing #37

erikreedstrom opened this issue Mar 13, 2012 · 2 comments

Comments

@erikreedstrom
Copy link

Route globbing is not supported properly in js-routes for Rails 3.2. NodeType.STAR should be an equivalent case to NodeType.GROUP; currently it's commented out. You can easily fix by adding above line 116 in lib/routes.js. This will allow wildcards to be supported without throwing an error.
@bogdan
Copy link
Collaborator

bogdan commented Mar 14, 2012

I've made the initial implementation that supports only a part of STAR use cases.

Some pending tests indicating the implementation difference between rails routes and js routes.
Currently don't have enough time to fix them. You can take a look and try to implement them.

@le0pard le0pard mentioned this issue Mar 28, 2013
Merged
@bogdan
Copy link
Collaborator

bogdan commented Apr 2, 2013

Released in version 0.9.0

@bogdan bogdan closed this as completed Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdan @erikreedstrom