Support route globbing #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope this pull request fix old issue #37 |
|
👍 this solves the issue I was experiencing with paths getting spurious |
| @@ -67,7 +67,7 @@ def draw_routes | |||
|
|
|||
| match "/other_optional/(:optional_id)" => "foo#foo", :as => :foo | |||
|
|
|||
| match 'books/*section/:title' => 'books#show', :as => :book | |||
| match 'books/:title/*section' => 'books#show', :as => :book | |||
There was a problem hiding this comment.
Why did you swap places of this?
In case we need to test this variant I would create another route.
May be should leave old tests for this route as some of the worked before.
And create another route as we implemented more use cases here.
There was a problem hiding this comment.
One moment, I will add another variant.
|
great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support route globbing in js-routes as in rails. Also fixed typeof problem, little cleanup of js.