#152 - prefix generated files with comment #154
Conversation
| @@ -1,3 +1,9 @@ | |||
|
|
|||
There was a problem hiding this comment.
Please remove this blank line.
There was a problem hiding this comment.
This is important for JS compressors that don't delete a first comment aka banner in a file and that blank line may cause them to assume there is no banner.
There was a problem hiding this comment.
@bogdan Curiously, if I remove that line and run the specs, the CoffeeScript compiler continues to output that file with the blank line at the top. If you'd like, I suppose we could pass the output through String#strip here: https://github.com/railsware/js-routes/blob/master/spec/spec_helper.rb#L138
There was a problem hiding this comment.
Yes, lets do strip in case it will not delete line break at the last line or lstrip otherwise.
There was a problem hiding this comment.
Alright, added lstrip to the spec helper code.
#152 - prefix generated files with comment
Fixes #152
Prefix generated files with a comment to indicate that the files are generated by the js-routes gem based on Rails routes for the given application.