Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The type must include the NotNull modifier when it is extended #31

Closed
stenin-nikita opened this issue Nov 20, 2017 · 2 comments
Closed

The type must include the NotNull modifier when it is extended #31

stenin-nikita opened this issue Nov 20, 2017 · 2 comments
Assignees
@SerafimArts
Labels
Bug RL/SDL

Comments

@stenin-nikita
Copy link
Member

  • Railt Version: dev-master
  • PHP Version: 7.1
  • Component: Reflection

Description:

The type must include the NotNull modifier when it is extended

Steps To Reproduce:

type Some {
    id: String
}

extend type Some {
    id: ID!
}

Expected result:

type Some {
    id: ID!
}

What happens instead?

type Some {
    id: ID
}
@SerafimArts SerafimArts self-assigned this Nov 20, 2017
@SerafimArts
Copy link
Member

SerafimArts commented Dec 26, 2017 •
edited

Tests:

  1. 9d7dcea
  2. d09fe7d

@SerafimArts
Copy link
Member

Fixed:

  1. 87ec0f0
  2. b47e560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SerafimArts SerafimArts

Labels
Bug RL/SDL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SerafimArts @stenin-nikita