Build plan snapshot testing #355
Conversation
|
I'm not sure, this kind of looks painful to maintain. |
| expression: plan | ||
| --- | ||
| { | ||
| "version": "0.2.9", |
There was a problem hiding this comment.
Do we have to input the version every time for each test? I presume we have to update it on every new version as well?
There was a problem hiding this comment.
No these are never edited manually. They are used to compare the build plan output and make sure there are no changes, if there are changes you use cargo insta review to go through them one by one and either accept or reject the updates.
For example, after manually editing a .snap file and running
cargo insta test --review -- --test generate_plan_tests
I get
Pressing a will automatically update the snapshot with the changes
Insta has tools to automatically review and update the snapshots. The snapshot files should never be edited manually. This video explains how it works fairly well |
What does this PR address?
Use cargo-insta for snapshot testing the build plan tests. This is useful since it will tests all parts of the build plan for each tests as opposed to just the parts that get manually asserted. This also makes updating the build plan format a lot easier since we don't have to go and edit a 900 line file everytime.
I am not snapshot testing and build plans that rely on
ARCH. This brings up a larger question in that we should be able to build for other platforms in the tests and not rely on theARCHconstant. But that should be fixed in another PR.