Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Node] Support Corepack properly #678

Merged
merged 5 commits into from
Nov 23, 2022
Merged

[Node] Support Corepack properly #678

merged 5 commits into from
Nov 23, 2022

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Nov 15, 2022

Follow-up to #621, #622

#622's implementation works for the most part, but ultimately this is the proper way it should be done

  • Tests are added/updated if needed
  • Docs are updated if needed

@ghost ghost added the release/patch Author patch release label Nov 15, 2022
@RDIL RDIL requested a review from coffee-cup November 16, 2022 16:12
@coffee-cup coffee-cup mentioned this pull request Nov 17, 2022
Closed
@RDIL RDIL requested a review from coffee-cup November 23, 2022 13:49
coffee-cup
coffee-cup approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@coffee-cup coffee-cup merged commit b5eaccc into railwayapp:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffee-cup coffee-cup coffee-cup approved these changes

Assignees
No one assigned
Labels
release/patch Author patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RDIL @coffee-cup