Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install on macOS #1

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix install on macOS #1

merged 1 commit into from
Apr 12, 2022

Conversation

wyattwalter
Copy link
Contributor

This plugin is currently silently failing on macOS, leaving me with a file with the contents:

Not Found

asdf believes the install was successful. Looking at the goss releases, I see that they're appending -alpha to the file name before the platform for both macOS and Windows currently.

PR changes the following:

  • the download will fail when curl encounters a 404
  • append -alpha to the end of the binary name on darwin and windows platforms when downloading
  • run tests on osx in Travis

I'm not sure when or if they'll change the binary name.

@raimon49
Copy link
Owner

Thank you! I was not aware that macOS/Windows was now supported.

I'm not sure when or if they'll change the binary name.

I agree, eventually the -alpha may change to -beta, or it may not come with anything.

@raimon49
Copy link
Owner

I have confirmed that it can be installed in my macOS environment.

Travis, which is linked to this Git repo, is now read only, so I will migrate it to GitHub Actions at a later date. Thanks for your P-R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants