Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filtering of input data #76

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Conversation

pohlt
Copy link

@pohlt pohlt commented Jul 27, 2020

Some package data contains Unicode characters which
might cause problems for certain output formats (in
particular ReST tables). This commit adds filtering
functionality by introducing two new options.

Some package data contains Unicode characters which
might cause problems for certain output formats (in
particular ReST tables). This commit adds filtering
functionality by introducing two new options.
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #76 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   98.45%   98.52%   +0.06%     
==========================================
  Files           1        1              
  Lines         323      338      +15     
==========================================
+ Hits          318      333      +15     
  Misses          5        5              
Impacted Files Coverage Δ
piplicenses.py 98.52% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1f8ea...e64b72c. Read the comment docs.

@raimon49
Copy link
Owner

raimon49 commented Aug 2, 2020

@pohlt Thanks!!

I've confirmed that your implementation of --filter-strings provides great behavior. 👍

$ pip-licenses -d --format=rest
+------+---------+---------+-----------------------------------------+
| Name | Version | License | Description                             |
+------+---------+---------+-----------------------------------------+
| poyo | 0.5.0   | MIT     | A lightweight YAML Parser for Python. 🐓 |
+------+---------+---------+-----------------------------------------+

$ pip-licenses -d --format=rest --filter-strings
+------+---------+---------+----------------------------------------+
| Name | Version | License | Description                            |
+------+---------+---------+----------------------------------------+
| poyo | 0.5.0   | MIT     | A lightweight YAML Parser for Python.  |
+------+---------+---------+----------------------------------------+

After merging this P-R I plan on shipping the next version 2.3.0.

@raimon49 raimon49 merged commit 454033f into raimon49:master Aug 2, 2020
@raimon49 raimon49 mentioned this pull request Oct 25, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants