Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BX-1357 #1404

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix: BX-1357 #1404

merged 3 commits into from
Mar 21, 2024

Conversation

estebanmino
Copy link
Member

Fixes BX-1357
Figma link (if any):

What changed (plus any additional context for devs)

updating logic to match ticket

Screen recordings / screenshots

https://www.loom.com/share/0c0be25e01164468bb849db812b120f6

What to test

@linear Linear
Copy link

linear bot commented Mar 14, 2024

BX-1357 Connect to dapp toast doesn't immediately show up after switching wallets

@estebanmino estebanmino marked this pull request as ready for review March 14, 2024 16:22
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0983acc97381d67d53b2a2aae3ab80cb8fbf7673.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c928e0ac6b2fe46842a4f0ecde88b6f58e399861.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c928e0ac6b2fe46842a4f0ecde88b6f58e399861.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6ba4f7f3e2be1f9cee417697d9de40b5ac434143.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6ba4f7f3e2be1f9cee417697d9de40b5ac434143.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-7a841e66e5e67aa0891129012750bd41c99f59c4.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-3783f5b273a1e70a190e3752ca78b1ccaf255ec4.zip

@estebanmino estebanmino added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Mar 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2024
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-364075cc047d0ed4a69881bb8aa62e2cfbfc0f12.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-364075cc047d0ed4a69881bb8aa62e2cfbfc0f12.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ce900de87db229a78f667106007f9f59d3093ea4.zip

@DanielSinclair DanielSinclair added this pull request to the merge queue Mar 21, 2024
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-9629d71adc54815b9be7906a6a58defc643ea417.zip

Merged via the queue into master with commit 7bd2b84 Mar 21, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @esteban/BX-1357 branch March 21, 2024 19:24
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-7bd2b841e7407537d9d6e2aa1b01b5f434c84d7b.zip

greg-schrammel pushed a commit that referenced this pull request Mar 27, 2024
@estebanmino @DanielSinclair @greg-schrammel
fix: BX-1357 (#1404)
45d57f5 
Co-authored-by: Daniel Sinclair <d@niel.nyc>
@DanielSinclair DanielSinclair mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@estebanmino @greg-schrammel @derHowie @DanielSinclair